fix(compiler): strip abstract keyword from class expressions in JIT mode#157
Merged
Brooooooklyn merged 2 commits intovoidzero-dev:mainfrom Mar 24, 2026
Merged
Conversation
Member
|
Should we use oxc-transform in JIT mode? |
…nsformer Add a `strip_typescript()` post-pass after JIT text-edits that uses oxc_transformer + oxc_codegen to convert TypeScript → JavaScript. This handles abstract members, type annotations, parameter properties, and other TS-only syntax that previously leaked into JIT output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ashley-hunter
force-pushed
the
fix/abstract-class
branch
from
5d9864d to
48cecda
Compare
Contributor
Author
|
Thanks for the suggestion! And great work on the project - it's amazing! I have added in oxc-transform for JIT transpilation. I did have to retain the abstract stripping change because of how we convert the class to a class expression which would result in invalid TS if it abstract keyword was retained - but any feedback or suggestions let me know! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
Summary
abstractkeyword when converting class declarations to class expressions (let X = class X)abstractmodifier, so it must be removed during the JIT transformTest plan
test_jit_abstract_classcovering exported abstract class with@Injectable()abstract classdoes not appear in outputlet X = class X)__decoratecall is present